Oboe: Add device specific Quirks for Samsung #734
Conversation
Use a minimum of 2 bursts for MMAP on Exynos devices. Add OboeGlobals::setWorkaroundEnabled() for testing so we can repro AAudio bugs using Oboe. Test: run OboeTester, look at MMAP output buffer size min Test: Disable and enable workarounds from MainActivity.
dturner
added
the
requires device
Bump OboeTester version number to 1.5.22 Bump Oboe version number to 1.3.1
|
Tested on Samsung Galaxy S9 SM-G960F Build number PPR1.180610.011.G960FXXU2CSA2 (Exynos 9810) Setup:
Steps to test (workarounds OFF):
Outcome:
Steps to test (workarounds ON)
Outcome:
Summary: Increasing the buffer size definitely reduces the number of glitches, but doesn't solve the problem entirely. |
| @@ -495,6 +495,25 @@ namespace oboe { | |||
| int64_t timestamp; // in nanoseconds | |||
| }; | |||
|
|
|||
| class OboeGlobals { | |||
There was a problem hiding this comment.
I'm fine with the workarounds being set here. I wonder if the default stream values should be moved into this class as well.
There was a problem hiding this comment.
Add getters/setters for the default stream values e.g. setOpenSLESDefaultSampleRate etc
Add comment saying that direct access to DefaultStreamValues is deprecated.
There was a problem hiding this comment.
One other thing. It might be better to name this Globals rather than OboeGlobals since this is already in the oboe namespace.
|
@dturner Take a look at the S9 properties to correctly identify it, then choose a buffer size which eliminates glitches. |
|
Do |
|
Will it be included on the 1.3.3 then ? The version was bumped from the quirksize branch but not merged even at oboe 1.3.2 |
Use a minimum of 2 bursts for MMAP on Exynos devices.
Add OboeGlobals::setWorkaroundEnabled() for testing
so we can repro AAudio bugs using Oboe.
Note Oboe API change. OboeGlobals added.
Test: run OboeTester, look at MMAP output buffer size min
Test: Disable and enable workarounds from MainActivity.